Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Remove init segment on formats without init segment #7060

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix(HLS): Remove init segment on formats without init segment #7060

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd06e17
fix(HLS): Remove init segment on formats without init segment
avelad Jul 18, 2024
12b8403
Use Set instead of Array
avelad Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lib/hls/hls_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3698,6 +3698,9 @@ shaka.hls.HlsParser = class {
const pMimeType = getMimeType(pUri);
if (pMimeType) {
partial.mimeType = pMimeType;
if (HlsParser.MIME_TYPES_WITHOUT_INIT_SEGMENT_.has(pMimeType)) {
partial.initSegmentReference = null;
}
}
partialSegmentRefs.push(partial);

Expand Down Expand Up @@ -3809,6 +3812,9 @@ shaka.hls.HlsParser = class {
const mimeType = getMimeType(hlsSegment.verbatimSegmentUri);
if (mimeType) {
reference.mimeType = mimeType;
if (HlsParser.MIME_TYPES_WITHOUT_INIT_SEGMENT_.has(mimeType)) {
reference.initSegmentReference = null;
}
}

if (segmentWithByteRangeOptimization) {
Expand Down Expand Up @@ -5011,6 +5017,19 @@ shaka.hls.HlsParser.EXTENSION_MAP_BY_CONTENT_TYPE_ = {
};


/**
* MIME types without init segment.
*
* @const {!Set.<string>}
* @private
*/
shaka.hls.HlsParser.MIME_TYPES_WITHOUT_INIT_SEGMENT_ = new Set([
'video/mp2t',
// Containerless types
...shaka.util.MimeUtils.RAW_FORMATS,
]);


/**
* @typedef {function(!shaka.hls.Tag, string):?shaka.extern.DrmInfo}
* @private
Expand Down
Loading