Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix filtering video/audio streams without bandwidth #7008

Merged
merged 3 commits into from
Jul 10, 2024
Merged

fix(HLS): Fix filtering video/audio streams without bandwidth #7008

merged 3 commits into from
Jul 10, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 9, 2024

Fixes #7007

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 9, 2024
@avelad avelad added this to the v4.11 milestone Jul 9, 2024
@avelad avelad requested a review from theodab July 9, 2024 07:46
@avelad avelad mentioned this pull request Jul 9, 2024
Closed
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@vanminhquangtri
Copy link

Hello @avelad I see there're 7 failing checks. Can you please re-test this.
Thank you.

@theodab
Copy link
Contributor

theodab commented Jul 10, 2024

Hello @avelad I see there're 7 failing checks. Can you please re-test this. Thank you.

We have a number of known test failures right now. They're largely problems with our IMA tests, and are unrelated to this PR.

theodab
theodab requested changes Jul 10, 2024
View reviewed changes
@avelad avelad requested a review from theodab July 10, 2024 06:40
theodab
theodab requested changes Jul 10, 2024
View reviewed changes
@avelad avelad requested a review from theodab July 10, 2024 06:59
@avelad avelad merged commit 64430ed into shaka-project:main Jul 10, 2024
8 of 16 checks passed
@avelad avelad deleted the hls-stream-filtering branch July 10, 2024 07:14
@shaka-bot shaka-bot mentioned this pull request Jul 10, 2024
Merged
avelad added a commit that referenced this pull request Jul 10, 2024
@avelad
fix(HLS): Fix filtering video/audio streams without bandwidth (#7008)
8a078d1 
Fixes #7007
@shaka-bot shaka-bot mentioned this pull request Jul 10, 2024
Merged
@vanminhquangtri
Copy link

Hello @avelad , so I will wait for you to public version 4.11.0, is this correct?

avelad added a commit that referenced this pull request Jul 10, 2024
@avelad
fix(HLS): Fix filtering video/audio streams without bandwidth (#7008)
529db5b 
Fixes #7007
@shaka-bot shaka-bot mentioned this pull request Jul 10, 2024
Merged
@avelad
Copy link
Member Author

avelad commented Jul 10, 2024

Hello @avelad , so I will wait for you to public version 4.11.0, is this correct?

It will be included in the following releases (4.9.16 and 4.10.4), they should be released today, but I still have to pass the tests before releasing them.

@vanminhquangtri
Copy link

Great @avelad , thank you

@vanminhquangtri vanminhquangtri mentioned this pull request Aug 13, 2024
Closed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 8, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.

Shaka not detect all resolutions of manifest
4 participants
@avelad @shaka-bot @vanminhquangtri @theodab