test: Readable order for ad test setup #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For readability, the order of before*/after* functions should be the same as their execution order: - beforeAll - beforeEach - afterEach - afterAll This fixes the order for ad tests.
|
Incremental code coverage: No instrumented code was changed. |
avelad
approved these changes
Aug 15, 2023
avelad
added
the
component: tests
joeyparrish
added a commit
that referenced
this pull request
Aug 19, 2023
For readability, the order of before*/after* functions should be the same as their execution order: - beforeAll - beforeEach - afterEach - afterAll This fixes the order for ad tests.
joeyparrish
added a commit
that referenced
this pull request
Aug 20, 2023
For readability, the order of before*/after* functions should be the same as their execution order: - beforeAll - beforeEach - afterEach - afterAll This fixes the order for ad tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For readability, the order of before*/after* functions should be the same as their execution order:
This fixes the order for ad tests.