Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update Chrome-Mac native screenshots #4546

Merged

Conversation

joeyparrish
Copy link
Member

Native text rendering has changed in Chrome 106 on Mac.

Native text rendering has changed in Chrome 106 on Mac.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Incremental code coverage: 89.47%

littlespex
littlespex previously approved these changes Oct 5, 2022
@joeyparrish
Copy link
Member Author

Hrm... failing on Chrome 105 in GitHub's environment. Looks like I need to skip those tests on older versions.

@joeyparrish
Copy link
Member Author

Should be fixed now, but we'll need to see the results of the next test run to be sure.

@joeyparrish
Copy link
Member Author

Yes, it seems that fixed it.

@avelad avelad added the component: tests The issue involves our automated tests (generally; otherwise use a more specific component) label Oct 5, 2022
@avelad avelad added this to the v4.3 milestone Oct 5, 2022
@joeyparrish joeyparrish merged commit da87c39 into shaka-project:main Oct 5, 2022
@joeyparrish joeyparrish deleted the update-chrome-mac-screenshots branch October 5, 2022 15:44
JulianDomingo pushed a commit that referenced this pull request Oct 6, 2022
Native text rendering has changed in Chrome 106 on Mac.
JulianDomingo pushed a commit that referenced this pull request Oct 6, 2022
Native text rendering has changed in Chrome 106 on Mac.
JulianDomingo pushed a commit that referenced this pull request Oct 7, 2022
Native text rendering has changed in Chrome 106 on Mac.
JulianDomingo pushed a commit that referenced this pull request Oct 7, 2022
Native text rendering has changed in Chrome 106 on Mac.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: tests The issue involves our automated tests (generally; otherwise use a more specific component) status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants