-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update Chrome-Mac native screenshots #4546
Merged
joeyparrish
merged 2 commits into
shaka-project:main
from
joeyparrish:update-chrome-mac-screenshots
Oct 5, 2022
Merged
test: Update Chrome-Mac native screenshots #4546
joeyparrish
merged 2 commits into
shaka-project:main
from
joeyparrish:update-chrome-mac-screenshots
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native text rendering has changed in Chrome 106 on Mac.
Incremental code coverage: 89.47% |
littlespex
previously approved these changes
Oct 5, 2022
Hrm... failing on Chrome 105 in GitHub's environment. Looks like I need to skip those tests on older versions. |
Should be fixed now, but we'll need to see the results of the next test run to be sure. |
Yes, it seems that fixed it. |
avelad
approved these changes
Oct 5, 2022
JulianDomingo
pushed a commit
that referenced
this pull request
Oct 6, 2022
Native text rendering has changed in Chrome 106 on Mac.
JulianDomingo
pushed a commit
that referenced
this pull request
Oct 6, 2022
Native text rendering has changed in Chrome 106 on Mac.
JulianDomingo
pushed a commit
that referenced
this pull request
Oct 7, 2022
Native text rendering has changed in Chrome 106 on Mac.
JulianDomingo
pushed a commit
that referenced
this pull request
Oct 7, 2022
Native text rendering has changed in Chrome 106 on Mac.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: tests
The issue involves our automated tests (generally; otherwise use a more specific component)
status: archived
Archived and locked; will not be updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native text rendering has changed in Chrome 106 on Mac.