Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net): Allow preventDefault() on retry event #8058

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix(net): Allow preventDefault() on retry event #8058

merged 1 commit into from
Feb 11, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 11, 2025

Fixes #8041

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: networking The issue involves the networking system of Shaka Player labels Feb 11, 2025
@avelad avelad added this to the v4.14 milestone Feb 11, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

joeyparrish
joeyparrish approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@rbertramResi
Copy link

Should docs be updated as well or is that done somewhere separately?
Throwing the error is shown here under Custom Handling of Retries:

https://shaka-player-demo.appspot.com/docs/api/tutorial-errors.html

@avelad avelad merged commit a30f1da into shaka-project:main Feb 11, 2025
23 checks passed
@shaka-bot shaka-bot mentioned this pull request Feb 11, 2025
Open
@avelad avelad deleted the rety-event branch February 12, 2025 09:50
avelad added a commit that referenced this pull request Feb 17, 2025
@avelad
fix(net): Allow preventDefault() on retry event (#8058)
01125cd 
Fixes #8041
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2025
Merged
avelad added a commit that referenced this pull request Feb 17, 2025
@avelad
fix(net): Allow preventDefault() on retry event (#8058)
a514199 
Fixes #8041
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2025
Merged
joeyparrish pushed a commit that referenced this pull request Feb 22, 2025
@avelad @joeyparrish
fix(net): Allow preventDefault() on retry event (#8058)
c0e18fc 
Fixes #8041
@shaka-bot shaka-bot mentioned this pull request Feb 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: networking The issue involves the networking system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.14
Development

Successfully merging this pull request may close these issues.

Throwing in networking engine retry listener doesn't appear to prevent retries
4 participants
@avelad @shaka-bot @rbertramResi @joeyparrish