Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Fix DASH_DUPLICATE_REPRESENTATION_ID error when using supplemental codec #7961

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(DASH): Fix DASH_DUPLICATE_REPRESENTATION_ID error when using supplemental codec #7961

merged 1 commit into from
Jan 28, 2025
+16 −6

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 28, 2025

Fixes #7948

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Jan 28, 2025
@avelad avelad added this to the v4.14 milestone Jan 28, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 66ca230 into shaka-project:main Jan 28, 2025
23 checks passed
@shaka-bot shaka-bot mentioned this pull request Jan 28, 2025
Open
@avelad avelad deleted the dash-supplementalCodecs branch January 28, 2025 10:49
@seanbecker15 seanbecker15 mentioned this pull request Jan 28, 2025
Closed
avelad added a commit that referenced this pull request Jan 29, 2025
@avelad
fix(DASH): Fix DASH_DUPLICATE_REPRESENTATION_ID error when using supp…
b183197 
…lemental codec (#7961)

Fixes #7948
@shaka-bot shaka-bot mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.14
Development

Successfully merging this pull request may close these issues.

DASH_DUPLICATE_REPRESENTATION_ID error when using supplemental codec with dynamic manifest
3 participants
@avelad @shaka-bot @tykus160