-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Offline): Allow downloading AES content #7827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
d6e8419
to
f392ab1
Compare
Incremental code coverage: 100.00% |
f392ab1
to
4dbd2ff
Compare
Also adds integration tests for DASH AES-128 and HLS SAMPLE-AES download and playback
4dbd2ff
to
31ab38c
Compare
theodab
requested changes
Jan 6, 2025
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
theodab
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: offline
The issue involves the offline storage system of Shaka Player
priority: P2
Smaller impact or easy workaround
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds integration tests for DASH AES-128, HLS AES-256 and HLS SAMPLE-AES download and playback