Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use source tags instead of src attribute #7406

Merged
merged 3 commits into from
Oct 15, 2024
Merged

feat: Use source tags instead of src attribute #7406

merged 3 commits into from
Oct 15, 2024

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented Oct 8, 2024

Needed for #5022

This PR does not enable AirPlay on MSE yet, but moves shaka from using src attribute to source tags. With this change we will be able to enable it more easily, as src and source should not be used together.

@tykus160 tykus160 added type: enhancement New feature or request priority: P3 Useful but not urgent labels Oct 8, 2024
@tykus160 tykus160 requested review from joeyparrish, avelad and theodab and removed request for avelad October 8, 2024 12:12
@avelad
Copy link
Member

avelad commented Oct 8, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7406

@shaka-bot
Copy link
Collaborator

shaka-bot commented Oct 8, 2024 •
edited
Loading

Incremental code coverage: 92.59%

@avelad avelad added this to the v4.12 milestone Oct 9, 2024
theodab
theodab requested changes Oct 9, 2024
View reviewed changes
@tykus160 tykus160 requested a review from theodab October 10, 2024 08:40
@tykus160
Copy link
Member Author

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@tykus160: Lab tests started with arguments:

  • pr=7406

@tykus160
Copy link
Member Author

tykus160 commented Oct 10, 2024 •
edited
Loading

Firefox Windows on Selenium fails on scenario unloads properly after DRM error. It doesn't seem to be an issue on GitHub runner, I'm also not able to reproduce it on my PC.
I haven't noticed it happens also on main branch.

@tykus160 tykus160 merged commit 445b0ce into shaka-project:main Oct 15, 2024
31 of 33 checks passed
@tykus160 tykus160 deleted the wt-source-child branch October 15, 2024 10:47
@shaka-bot shaka-bot mentioned this pull request Oct 11, 2024
Merged
@alexandercerutti
Copy link
Contributor

Ouch. This change broke our code and the assumption that video tag had the src attribute 😅

@tykus160
Copy link
Member Author

@alexandercerutti sorry 😅 you can try to use currentSrc instead!

@alexandercerutti
Copy link
Contributor

Still, I do have to update the code 😂

I think I don't need the check anymore tho. I'll follow your suggestion if I'll need it. Thank you 👍

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 14, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.
5 participants
@tykus160 @avelad @shaka-bot @alexandercerutti @theodab