fix(preload): Set manifest before initializing DRM #7359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
Incremental code coverage: 100.00% |
This comment was marked as resolved.
This comment was marked as resolved.
tykus160
reviewed
Sep 24, 2024
lib/player.js
Outdated
Comment on lines
1704
to
1708
| const promises = [ | ||
| preloadManager.waitForFinish(), | ||
| preloadManager.waitForManifest(), | ||
| ]; | ||
| await Promise.race(promises); |
There was a problem hiding this comment.
I wonder couldn't we reject manifest promise when an error occurs or is it not enough?
There was a problem hiding this comment.
I was doing that at first, but that was what was causing the test failures, I believe.
There was a problem hiding this comment.
Maybe this race should be moved to waitForManifest() method then?
There was a problem hiding this comment.
I tend to agree. Let's move it, please.
There was a problem hiding this comment.
Okay, trying that out.
joeyparrish
reviewed
Sep 24, 2024
There was a problem hiding this comment.
This looks fine to me, but:
- I'd like @tykus160 to approve
- I'd like a PR description explaining why this is important to do in this order (e.g. what goes wrong if we don't, what benefit we get from this, etc)
Okay, I've added a description. |
tykus160
approved these changes
Sep 24, 2024
joeyparrish
approved these changes
Sep 24, 2024
avelad
pushed a commit
that referenced
this pull request
Sep 25, 2024
Previously, there were situations where, when handling `trackschanged` events, the manifest would not yet have been copied from the preload manager to the player. This would prevent developers from properly handling those events. This PR changes the order of operations slightly, such that the manifest is copied over earlier.
avelad
pushed a commit
that referenced
this pull request
Sep 25, 2024
Previously, there were situations where, when handling `trackschanged` events, the manifest would not yet have been copied from the preload manager to the player. This would prevent developers from properly handling those events. This PR changes the order of operations slightly, such that the manifest is copied over earlier.
joeyparrish
pushed a commit
that referenced
this pull request
Sep 26, 2024
Previously, there were situations where, when handling `trackschanged` events, the manifest would not yet have been copied from the preload manager to the player. This would prevent developers from properly handling those events. This PR changes the order of operations slightly, such that the manifest is copied over earlier. Backported to v4.9.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were situations where, when handling
trackschangedevents, the manifest would not yet have beencopied from the preload manager to the player. This would prevent developers from properly handling those events.
This PR changes the order of operations slightly, such that the manifest is copied over earlier.