Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Active track state on variantchanged and adaptation events #7350

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

zangue
Copy link
Contributor

@zangue zangue commented Sep 22, 2024

This change ensures that the active states of tracks for "variantchanged" and "adaptation" events are accurate.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad requested a review from tykus160 September 23, 2024 07:44
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Sep 23, 2024
@avelad avelad added this to the v4.12 milestone Sep 23, 2024
@avelad avelad merged commit c15ca1d into shaka-project:main Sep 23, 2024
17 of 18 checks passed
avelad pushed a commit that referenced this pull request Sep 24, 2024
This change ensures that the active states of tracks for
"variantchanged" and "adaptation" events are accurate.
avelad pushed a commit that referenced this pull request Sep 24, 2024
This change ensures that the active states of tracks for
"variantchanged" and "adaptation" events are accurate.
joeyparrish pushed a commit that referenced this pull request Sep 26, 2024
This change ensures that the active states of tracks for
"variantchanged" and "adaptation" events are accurate.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants