-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(net): Remove AbortController
polyfill
#7149
fix(net): Remove AbortController
polyfill
#7149
Conversation
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
Incremental code coverage: 97.22% |
i think that is necessary for hls parser, @joeyparrish i’m on holidays, can you review it? thanks! |
Ah sorry, I missed that. My point still stands though - shaka has network abstraction layer and |
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether or not this is a mistake. Please take a look!
The merge conflicts are trivial. I changed abort_controller.js in #7176 for an easy cherry-pick. You can just delete the updated version and merge. |
@tykus160, I have prepared new releases for v4.10.x and v4.9.x, but I will wait another day to see this get finished and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this mostly looks good (besides Joey's comment).
AbortController
polyfill attaches to the global object and it messes up with feature detection for projects that are using shaka. As it is not able to properly abort ongoing requests, it doesn't give much value.