Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebVTT): Re-add rollover logic #7104

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 24, 2024

Fixes: #6448

Revert 9ab54d1

@avelad avelad requested a review from theodab July 24, 2024 12:10
@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release component: WebVTT The issue involves WebVTT subtitles specifically labels Jul 24, 2024
@avelad avelad added this to the v4.11 milestone Jul 24, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@theodab theodab merged commit 0708379 into shaka-project:main Jul 26, 2024
17 of 20 checks passed
@avelad avelad deleted the regression-webvtt-hls branch August 19, 2024 06:35
avelad added a commit that referenced this pull request Aug 19, 2024
avelad added a commit that referenced this pull request Aug 19, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 24, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shaka 4.6.16 doesn't show WebVTT subtitles
3 participants