fix(Ads): Don't show duplicate SKIP UI in IMA CS #7084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 81.82% |
theodab
requested changes
Jul 22, 2024
There was a problem hiding this comment.
I don't think I like this as a solution. It puts the burden of knowing the implementation details of different ad types into the UI library, instead of the ads code where it belongs. It also means that if we add another type of ads that have a built-in skip UI, that if condition will become longer and more complicated.
I'd prefer if, instead, you added a method with a name like needsSkipUI that returns false for client side ads and true for everything else, and then the UI can just query that.
theodab
approved these changes
Jul 23, 2024
avelad
added a commit
that referenced
this pull request
Jul 24, 2024
SKIP UI in IMA CS can not be disabled, see: https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/faq#13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SKIP UI in IMA CS can not be disabled, see: https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/faq#13