Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Show the ad marker in the seek bar when there are some intersections #6990

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix(UI): Show the ad marker in the seek bar when there are some intersections #6990

merged 1 commit into from
Jul 8, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 5, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Jul 5, 2024
@avelad avelad added this to the v4.11 milestone Jul 5, 2024
@avelad avelad requested a review from theodab July 5, 2024 10:10
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 28.57%

@avelad avelad merged commit 247037e into shaka-project:main Jul 8, 2024
13 of 20 checks passed
@shaka-bot shaka-bot mentioned this pull request Jul 8, 2024
Merged
@avelad avelad deleted the ui-ads branch July 8, 2024 07:13
avelad added a commit that referenced this pull request Jul 8, 2024
@avelad
fix(UI): Show the ad marker in the seek bar when there are some inter…
0dd6435 
…sections (#6990)
@shaka-bot shaka-bot mentioned this pull request Jul 8, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 6, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab