Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HLS): Build closed captions metadata on-the-fly #6700

Merged
merged 2 commits into from
May 30, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 29, 2024

Closes #1826

Also fixes variable substitution when using getMediaPlaylistBasicInfo_

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles priority: P4 Nice to have / wishful thinking labels May 29, 2024
@avelad avelad modified the milestones: Backlog, v4.9 May 29, 2024
@avelad avelad requested review from joeyparrish and theodab May 29, 2024 11:57
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 95.52%

externs/shaka/player.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab May 30, 2024 07:52
@avelad avelad merged commit 082f897 into shaka-project:main May 30, 2024
15 of 16 checks passed
@avelad avelad deleted the cc-hls branch May 30, 2024 09:05
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 29, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build TS caption metadata on-the-fly
3 participants