Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config to clear decodingInfo cache on unload #6678

Merged
merged 4 commits into from
May 27, 2024

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented May 27, 2024

On PlayStation, cached MediaKeySystemAccess objects may corrupt after several playbacks, and they are not able anymore to properly create MediaKeys objects. To prevent it, clear the cache after each playback.
Make it configurable via streaming.clearDecodingCache.

@shaka-bot
Copy link
Collaborator

shaka-bot commented May 27, 2024

Incremental code coverage: 97.65%

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround platform: Playstation 4 Issues affecting Playstation 4 platform: Playstation 5 Issues affecting Playstation 5 labels May 27, 2024
@avelad avelad modified the milestone: v4.9 May 27, 2024
@avelad avelad requested review from joeyparrish and theodab May 27, 2024 11:01
lib/player.js Outdated Show resolved Hide resolved
demo/config.js Outdated Show resolved Hide resolved
lib/player.js Outdated Show resolved Hide resolved
@tykus160 tykus160 changed the title fix: PlayStation - clear MediaKeySystemAccess cache feat: add config to clear MediaKeySystemAccess cache on unload May 27, 2024
@avelad avelad added type: enhancement New feature or request and removed type: bug Something isn't working correctly labels May 27, 2024
@tykus160 tykus160 changed the title feat: add config to clear MediaKeySystemAccess cache on unload feat: add config to clear decodingInfo cache on unload May 27, 2024
@avelad avelad merged commit e0eeb5b into shaka-project:main May 27, 2024
19 checks passed
@tykus160 tykus160 deleted the wt-clear-mksa-cache branch May 27, 2024 12:33
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 26, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Playstation 4 Issues affecting Playstation 4 platform: Playstation 5 Issues affecting Playstation 5 priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants