Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DASH): Add MPD Chaining support #6641

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented May 20, 2024

Close #3926

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: DASH The issue involves the MPEG DASH manifest format labels May 20, 2024
@avelad avelad added this to the v4.9 milestone May 20, 2024
@avelad
Copy link
Member Author

avelad commented May 20, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6641

@shaka-bot
Copy link
Collaborator

shaka-bot commented May 20, 2024

Incremental code coverage: 91.67%

Copy link
Contributor

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much quicker than expected!

lib/player.js Outdated Show resolved Hide resolved
lib/player.js Show resolved Hide resolved
lib/player.js Show resolved Hide resolved
lib/player.js Outdated Show resolved Hide resolved
@avelad
Copy link
Member Author

avelad commented May 21, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6641

Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be worth it to add an optional new UI element for this, like a "skip to next" button or something.
I guess that'd be better as a follow-up PR, if so.

externs/shaka/player.js Outdated Show resolved Hide resolved
externs/shaka/player.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab May 21, 2024 07:34
@avelad avelad merged commit 82c5149 into shaka-project:main May 21, 2024
16 checks passed
@avelad avelad deleted the mpd-chaining branch May 21, 2024 07:58
if (this.preloadNextUrl_ &&
this.assetUri_ != this.preloadNextUrl_.getAssetUri()) {
if (!this.preloadNextUrl_.isDestroyed()) {
this.preloadNextUrl_.destroy();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be awaited, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :(

@shreyaskaundinya
Copy link

shreyaskaundinya commented Jun 2, 2024

Is there any documentation on how to use this feature?!
@avelad @joeyparrish

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPD Chaining support in Dash
6 participants