-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DASH): Add MPD Chaining support #6641
Conversation
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
Incremental code coverage: 91.67% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much quicker than expected!
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be worth it to add an optional new UI element for this, like a "skip to next" button or something.
I guess that'd be better as a follow-up PR, if so.
if (this.preloadNextUrl_ && | ||
this.assetUri_ != this.preloadNextUrl_.getAssetUri()) { | ||
if (!this.preloadNextUrl_.isDestroyed()) { | ||
this.preloadNextUrl_.destroy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be awaited, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :(
Is there any documentation on how to use this feature?! |
Close #3926