fix: Destroy preload managers on player destroy #6576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A PreloadManager can only be used on the Player instance that created it. That means that once that Player instance is destroyed any PreloadManagers it made are basically useless, so they should be automatically destroyed too.
theodab
force-pushed
the
autoDestroyPreloadManagerBranch
branch
from
d114005 to
b256e99
Compare
avelad
approved these changes
May 10, 2024
avelad
added
the
priority: P1
|
Incremental code coverage: 90.00% |
joeyparrish
reviewed
May 10, 2024
| } | ||
| } | ||
| await Promise.all(preloadManagerDestroys); | ||
| this.createdPreloadManagers_ = []; |
There was a problem hiding this comment.
I would have preferred this above await. Probably not crucial, but ideally you would empty that array right after initiating all those promises, rather than after they complete.
theodab
added a commit
to theodab/shaka-player
that referenced
this pull request
May 11, 2024
Based on a comment on shaka-project#6576
theodab
added a commit
that referenced
this pull request
May 11, 2024
This could be relevant if destroy() is called multiple times in a row. Based on a comment on #6576
avelad
pushed a commit
that referenced
this pull request
May 13, 2024
A PreloadManager can only be used on the Player instance that created it. That means that once that Player instance is destroyed any PreloadManagers it made are basically useless, so they should be automatically destroyed too.
avelad
pushed a commit
that referenced
this pull request
May 13, 2024
This could be relevant if destroy() is called multiple times in a row. Based on a comment on #6576
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PreloadManager can only be used on the Player instance that created it. That means that once that Player instance is destroyed any PreloadManagers it made are basically useless, so they should be automatically destroyed too.