Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix tXml conversion to DOMElement #6538

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented May 6, 2024

Fixes #6524

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels May 6, 2024
@avelad avelad added this to the v4.9 milestone May 6, 2024
lib/util/tXml.js Outdated Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad requested a review from littlespex May 6, 2024 17:40
@avelad avelad merged commit d494068 into shaka-project:main May 6, 2024
16 checks passed
joeyparrish pushed a commit that referenced this pull request May 6, 2024
@avelad avelad deleted the txml-error branch May 7, 2024 04:23
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 5, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute 'createElement' on 'Document'
4 participants