Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make UITextDisplayer constructor backward compatible #6532

Merged
merged 2 commits into from
May 6, 2024
Merged

fix: Make UITextDisplayer constructor backward compatible #6532

merged 2 commits into from
May 6, 2024

Conversation

MichaelSweden
Copy link
Contributor

Keep constructor backward compatible with earlier that had two arguments, i.e. make the new third optional for existing applications.

Fixes #6531

@MichaelSweden
fix: Make UITextDisplayer constructor backward compatible
a34ca5c 
Keep constructor backward compatible with earlier that had two arguments,
i.e. make the new third optional for existing applications.

Fixes shaka-project#6531
@MichaelSweden
Copy link
Contributor Author

This will make it possible to run existing application that creates an UITextDisplayer object and only supply two arguments to the constructor. A test is added to check this. If the third argument is not given, the old value before PR #6477 is used. This fix issue #6531.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels May 6, 2024
@avelad avelad added this to the v4.9 milestone May 6, 2024
@avelad avelad merged commit d564be8 into shaka-project:main May 6, 2024
15 checks passed
@shaka-bot shaka-bot mentioned this pull request May 6, 2024
Merged
@MichaelSweden
Copy link
Contributor Author

Great Álvaro with the deprecate message. I have teested it, ok.
Sorry I was late this morning. I now see that you have commit it and also merge it. I will not take any action.
Thanks!

@MichaelSweden MichaelSweden deleted the issue6531 branch May 6, 2024 08:21
avelad added a commit that referenced this pull request May 6, 2024
@MichaelSweden @avelad
fix: Make UITextDisplayer constructor backward compatible (#6532)
6fc4e42 
Keep constructor backward compatible with earlier that had two
arguments, i.e. make the new third optional for existing applications.

Fixes #6531

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
@shaka-bot shaka-bot mentioned this pull request May 6, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 5, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

Exception in UITextDisplayer constructor
3 participants
@MichaelSweden @shaka-bot @avelad