Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Check encryptionScheme against MCap #6484

Merged
merged 5 commits into from
May 8, 2024
Merged

feat: Check encryptionScheme against MCap #6484

merged 5 commits into from
May 8, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 26, 2024

Closes #1419

@avelad avelad added type: enhancement New feature or request component: EME The issue involves the Encrypted Media Extensions web API priority: P1 Big impact or workaround impractical; resolve before feature release labels Apr 26, 2024
@avelad avelad marked this pull request as draft April 26, 2024 10:12
@avelad
Copy link
Member Author

avelad commented Apr 26, 2024

@joeyparrish This PR has dependency of shaka-project/eme-encryption-scheme-polyfill#62, so it's necessary resolve it first.

@avelad avelad requested a review from joeyparrish April 26, 2024 10:13
@avelad avelad modified the milestones: v4.8, v4.9 Apr 26, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

joeyparrish added a commit to joeyparrish/shaka-player that referenced this pull request Apr 29, 2024
@joeyparrish
feat: Add support for probing encryption scheme support
76e3edc 
This will add encryption schemes to the DRM support report generated
by probeSupport() and support.html.

Related to shaka-project/eme-encryption-scheme-polyfill#62, PR shaka-project#6484,
and issue shaka-project#1419.
@joeyparrish joeyparrish mentioned this pull request Apr 29, 2024
Merged
avelad added a commit that referenced this pull request May 6, 2024
@joeyparrish @avelad
feat: Add support for probing encryption scheme support (#6506)
2dea350 
This will add encryption schemes to the DRM support report generated by
probeSupport() and support.html.

Related to shaka-project/eme-encryption-scheme-polyfill#62, PR #6484,
and issue #1419.

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
@avelad avelad marked this pull request as ready for review May 7, 2024 16:32
@joeyparrish
Copy link
Member

@shaka-bot please test

@shaka-bot
Copy link
Collaborator

@joeyparrish: Lab tests started with arguments:

  • pr=6484

@avelad avelad requested a review from theodab May 8, 2024 08:51
@avelad avelad merged commit ec29f82 into shaka-project:main May 8, 2024
32 of 35 checks passed
@shaka-bot shaka-bot mentioned this pull request May 8, 2024
Merged
@avelad avelad deleted the mcap-encryptionScheme branch May 8, 2024 09:12
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 7, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: EME The issue involves the Encrypted Media Extensions web API priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

Check support for ContentProtection value="cbcs" in DASH
4 participants
@avelad @shaka-bot @joeyparrish @theodab