fix(demo): Remove max height of demo config tabs #6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each tab in the demo config had a max height of 1000px. That was not a problem previously, but the "streaming" config now has so many config values that it no longer fits into that limit. This PR removes that limit, by instead setting a max-height value of "fit-content". Unfortunately, doing that seems to break the open/close animation of the tabs, and makes it look kind of bad, so this also removes the animation entirely; it's better to have no animation than an ugly one.
theodab
added
type: bug
|
Incremental code coverage: No instrumented code was changed. |
avelad
approved these changes
Mar 6, 2024
avelad
pushed a commit
that referenced
this pull request
Apr 8, 2024
Each tab in the demo config had a max height of 1000px. That was not a problem previously, but the "streaming" config now has so many config values that it no longer fits into that limit. This PR removes that limit, by instead setting a max-height value of "fit-content". Unfortunately, doing that seems to break the open/close animation of the tabs, and makes it look kind of bad, so this also removes the animation entirely; it's better to have no animation than an ugly one.
avelad
pushed a commit
that referenced
this pull request
Apr 8, 2024
Each tab in the demo config had a max height of 1000px. That was not a problem previously, but the "streaming" config now has so many config values that it no longer fits into that limit. This PR removes that limit, by instead setting a max-height value of "fit-content". Unfortunately, doing that seems to break the open/close animation of the tabs, and makes it look kind of bad, so this also removes the animation entirely; it's better to have no animation than an ugly one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each tab in the demo config had a max height of 1000px. That was not a problem previously, but the "streaming" config now has so many config values that it no longer fits into that limit. This PR removes that limit, by instead setting a max-height value of "fit-content".
Unfortunately, doing that seems to break the open/close animation of the tabs, and makes it look kind of bad, so this also removes the animation entirely; it's better to have no animation than an ugly one.