Insufficient error test

[Robloche]

Following PR #5986, I found a new edge case.

When the HEAD method is not authorized, the server returns a 404 status code, ending up as the following error:

The error code is 1001, whereas shaka.util.Error.Code.HTTP_ERROR is 1002.
Hence, the GET request is never done.

I think the test should be:

    if (error && (error.code == shaka.util.Error.Code.HTTP_ERROR || error.code == shaka.util.Error.Code.BAD_HTTP_STATUS)) {
      request.method = 'GET';
      const response = await netEngine.request(type, request).promise;
      mimeType = response.headers['content-type'];
    }

And the same change should be done in lib/hls/hls_parser.js as well.

What do you think, @avelad?

[avelad]

@Robloche Is it normal behavior that if the HEAD method is not supported it returns a 404?

[Robloche]

No, you're right. Unsupported method should cause a 405 status, as described here:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405

But one cannot expect all servers to be properly configured, don't you think so?

[avelad]

You have convinced me, I will be happy to approve your PR to change it.

[Robloche]

Glad to read it! 😄

[Robloche]

PR #6044