Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Fix bad url when specify using a full WebVTT with BaseURL #5954

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(DASH): Fix bad url when specify using a full WebVTT with BaseURL #5954

merged 1 commit into from
Nov 29, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 29, 2023

No description provided.

@avelad
Copy link
Member Author

avelad commented Nov 29, 2023

Test stream: https://storage.googleapis.com/shaka-demo-assets/sintel/dash.mpd

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Nov 29, 2023
@avelad avelad added this to the v5.0 milestone Nov 29, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit ba85ece into shaka-project:main Nov 29, 2023
17 of 21 checks passed
@avelad avelad deleted the dash-subtitle-sintel-error branch November 29, 2023 16:34
@shaka-bot shaka-bot mentioned this pull request Nov 29, 2023
Merged
avelad added a commit that referenced this pull request Nov 30, 2023
@avelad
fix(DASH): Fix bad url when specify using a full WebVTT with BaseURL (#…
b77d73a 
…5954)
@shaka-bot shaka-bot mentioned this pull request Nov 30, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(DASH): Fix bad url when specify using a full WebVTT with BaseURL (s…
2d7e4fa 
…haka-project#5954)
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @littlespex