Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix mangled property in compiled mode in Content Steering #5887

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: Fix mangled property in compiled mode in Content Steering #5887

merged 1 commit into from
Nov 15, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 15, 2023 •
edited
Loading

Related to #5704

@avelad avelad added type: bug Something isn't working correctly priority: P3 Useful but not urgent labels Nov 15, 2023
@avelad avelad added this to the v4.6 milestone Nov 15, 2023
@avelad avelad added priority: P2 Smaller impact or easy workaround and removed priority: P3 Useful but not urgent labels Nov 15, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 0e62b8e into shaka-project:main Nov 15, 2023
20 of 22 checks passed
@avelad avelad deleted the ttl-content-steering branch November 15, 2023 17:19
@shaka-bot shaka-bot mentioned this pull request Nov 15, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix: Fix mangled property in compiled mode in Content Steering (shaka…
71f7c4b 
…-project#5887)

Related to shaka-project#5704
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 14, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillemcabrera guillemcabrera guillemcabrera approved these changes

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
4 participants
@avelad @shaka-bot @littlespex @guillemcabrera