fix: Fix variant filtering by preferredAudioChannelCount #5859
Conversation
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
There was a problem hiding this comment.
Overall I approve of this change.
It did make me realize that our extern descriptions for these preference values are kind of poorly written though.
preferredVideoCodecs, preferredAudioCodecs, and preferredDecodingAttributes are hard restrictions that are used to filter the manifest.
preferredAudioLanguage, preferredVariantRole, preferredAudioChannelCount (after this change), preferredVideoHdrLevel, preferredVideoLayout, and preferredAudioLabel are soft preferences that are used for our PreferenceBasedCriteria system.
Despite the different inner workings of these groups of configs, their names and descriptions don't really do much to tell the developer which is which. That seems like a failure of documentation to me...
Well, that's outside the scope of this PR.
Fixes #5858