fix: Fix chooseCodecsAndFilterManifest for similar frameRate #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
littlespex
reviewed
Oct 26, 2023
| @@ -128,7 +128,7 @@ shaka.util.StreamUtils = class { | |||
| const validVideoIds = []; | |||
| const validVideoStreamsMap = new Map(); | |||
| const getVideoGroupId = (stream) => { | |||
| return (stream.frameRate || 0) + (stream.hdr || ''); | |||
| return Math.round(stream.frameRate || 0) + (stream.hdr || ''); | |||
There was a problem hiding this comment.
Wouldn't this result in NTSC 29.97 and 30 being treated as the same FPS?
There was a problem hiding this comment.
Yes! But I think that nobody uses both in the same stream
theodab
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://storage.googleapis.com/shaka-demo-assets/sintel/dash.mpd
mp4 --> 12288/512 --> 24
webm --> 1000000/42000 --> 23.80952380952381