fix(HLS): Fix url management in HLS #5722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 93.75% |
theodab
approved these changes
Oct 6, 2023
# Conflicts: # lib/hls/hls_parser.js
theodab
approved these changes
Oct 6, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Oct 6, 2023
Fix variable substitution in: AES-128 key and EXT-X-SESSION-DATA urls. Fix to keep previous query params when using blocking playlist reload Simplifies and unifies URL management to allow Content Steering in the future
joeyparrish
pushed a commit
that referenced
this pull request
Oct 6, 2023
Fix variable substitution in: AES-128 key and EXT-X-SESSION-DATA urls. Fix to keep previous query params when using blocking playlist reload Simplifies and unifies URL management to allow Content Steering in the future Backported to v4.4.x
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
Fix variable substitution in: AES-128 key and EXT-X-SESSION-DATA urls. Fix to keep previous query params when using blocking playlist reload Simplifies and unifies URL management to allow Content Steering in the future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix variable substitution in: AES-128 key and EXT-X-SESSION-DATA urls.
Fix to keep previous query params when using blocking playlist reload
Simplifies and unifies URL management to allow Content Steering in the future