Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow PID change in TsParser #5681

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 26, 2023

This is necessary because some Live streams change audio or video PID when there are ads.

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 26, 2023
@avelad avelad added this to the v4.5 milestone Sep 26, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit d9b49d9 into shaka-project:main Sep 26, 2023
@avelad avelad deleted the ts-pid-change branch September 26, 2023 19:06
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
This is necessary because some Live streams change audio or video PID
when there are ads.
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
This is necessary because some Live streams change audio or video PID
when there are ads.
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
This is necessary because some Live streams change audio or video PID
when there are ads.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 25, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants