Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow generate muxed content with Mp4Generator #5555

Merged
merged 2 commits into from
Aug 30, 2023
Merged

feat: Allow generate muxed content with Mp4Generator #5555

merged 2 commits into from
Aug 30, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Aug 30, 2023 •
edited
Loading

This PR prepares the Mp4Generator to generate muxed content and also add support for generate HEVC content.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Aug 30, 2023
@avelad avelad added this to the v4.4 milestone Aug 30, 2023
@avelad avelad force-pushed the mp4-generator-muxed branch from 1236f20 to f6b9563 Compare August 30, 2023 11:08
@avelad avelad force-pushed the mp4-generator-muxed branch from f6b9563 to 1d6bfca Compare August 30, 2023 11:27
@github-actions
Copy link
Contributor

Incremental code coverage: 62.86%

theodab
theodab requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice any major problems, just a few issues with whitespace.

lib/util/mp4_generator.js Outdated Show resolved Hide resolved
lib/util/mp4_generator.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab August 30, 2023 12:36
@avelad avelad merged commit 1112d1d into shaka-project:main Aug 30, 2023
@avelad avelad deleted the mp4-generator-muxed branch August 30, 2023 14:38
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 29, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @theodab @shaka-bot