feat(MSS): Fix MSS PlayReady support #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This PR is feat instead of fix because MSS support hasn't been released yet and is only in the main branch |
avelad
added
type: enhancement
avelad
changed the title
|
Incremental code coverage: 51.16% |
joeyparrish
requested changes
Aug 16, 2023
lib/transmuxer/mss_transmuxer.js
Outdated
|
|
||
| if (isSENC) { | ||
| if (box._parsing) { | ||
| box.type = 'sepiff'; // Rename it to be recognized later |
There was a problem hiding this comment.
I don't understand this part. Could you elaborate on this comment?
joeyparrish
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5390