fix(HLS): Consider skipped segments to calculate next media sequence #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
diogoazevedos
changed the title
diogoazevedos
force-pushed
the
fix/ll-hls-compliance
branch
from
89720ae to
2b9edb1
Compare
|
Incremental code coverage: 100.00% |
diogoazevedos
force-pushed
the
fix/ll-hls-compliance
branch
from
2b9edb1 to
32e2510
Compare
joeyparrish
approved these changes
Jul 19, 2023
|
This didn't cherry-pick cleanly into v4.3.x or v4.2.x. If you believe a similar fix is necessary for those branches, please create a PR that targets v4.3.x and/or v4.2.x. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_HLS_msndirective must be the next media sequence number to block playlist reload. The actual logic uses theEXT-X-MEDIA-SEQUENCEplus the number of segments. However, a playlist may skip segments, so it should also considerEXT-X-SKIP:SKIPPED-SEGMENTS.