-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DASH): Add support for service descriptions #5394
Conversation
Let's just take the first one, it's the same as we do with the trickplay track.
We don't want to break the old configuration, so OR is perfect in this case. |
I have parsed many values from Latency and PlaybackRate but we are using just 2 of them, do you agree in removing others? |
In the context of this PR, yes. |
@adgllorente I forgot to comment before, add a parsing test of these new parameters in |
Incremental code coverage: 63.46% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll wait to pass all tests to merge it. Thanks for your contribution!
Changes
Doubts
this.manifest_.serviceDescription
ORthis.config_.streaming.liveSync
, should it be an AND?