Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Demo): Add Low Latency filter in demo page #5392

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

adgllorente
Copy link
Contributor

  • Allow filtering by low latency streams in demo page.

image

@avelad avelad added type: enhancement New feature or request component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent labels Jul 3, 2023
@avelad avelad added this to the v4.4 milestone Jul 3, 2023
@avelad avelad changed the title feat: Add Low Latency filter in demo page feat(Demo): Add Low Latency filter in demo page Jul 3, 2023
demo/locales/en.json Show resolved Hide resolved
Copy link
Member

@avelad avelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, low latency streams need a setExtraConfig in assets.js to enable LL on these assets.

@adgllorente
Copy link
Contributor Author

Also, low latency streams need a setExtraConfig in assets.js to enable LL on these assets.

With this extraConfig?

        streaming: {
          lowLatencyMode: true,
          autoLowLatencyMode: true,
        },

@avelad
Copy link
Member

avelad commented Jul 3, 2023

Also, low latency streams need a setExtraConfig in assets.js to enable LL on these assets.

With this extraConfig?

        streaming: {
          lowLatencyMode: true,
          autoLowLatencyMode: true,
        },

Only the following is necessary:

        streaming: {
          lowLatencyMode: true,
        },

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Incremental code coverage: No instrumented code was changed.

@adgllorente adgllorente requested a review from avelad July 3, 2023 13:39
@avelad avelad merged commit c378e10 into shaka-project:main Jul 3, 2023
@avelad
Copy link
Member

avelad commented Jul 3, 2023

@adgllorente Deployed in the nightly demo

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants