fix(DRM): broken keySystemsMapping due to multiple references of drmInfo #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Jul 3, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
…nfo (#5388) Different streams may share `drmInfo` references, which makes problem when `keySystemsMapping` config is used. Assuming we have config: ```js drm: { servers: { 'a.b.c': '...', }, keySystemsMapping: { 'a.b.c': 'd.e.f', }, } ``` on the first access to the `drmInfo` object `DrmEngine` will set server for `a.b.c` key system and replace key system to `d.e.f`. On the 2nd access DrmEngine will not find server config for `d.e.f` and thus will remove any server set. This issue can be easily mitigated by deduplicating `drmInfo` array.
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
…nfo (#5388) Different streams may share `drmInfo` references, which makes problem when `keySystemsMapping` config is used. Assuming we have config: ```js drm: { servers: { 'a.b.c': '...', }, keySystemsMapping: { 'a.b.c': 'd.e.f', }, } ``` on the first access to the `drmInfo` object `DrmEngine` will set server for `a.b.c` key system and replace key system to `d.e.f`. On the 2nd access DrmEngine will not find server config for `d.e.f` and thus will remove any server set. This issue can be easily mitigated by deduplicating `drmInfo` array.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different streams may share
drmInforeferences, which makes problem whenkeySystemsMappingconfig is used. Assuming we have config:on the first access to the
drmInfoobjectDrmEnginewill set server fora.b.ckey system and replace key system tod.e.f. On the 2nd access DrmEngine will not find server config ford.e.fand thus will remove any server set.This issue can be easily mitigated by deduplicating
drmInfoarray.