fix: Only parse/probe TS if the reference is not an MP4 and not WebM #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconz
changed the title
avelad
added
type: bug
|
Assuming no test failures, I'll merge as soon as the tests are complete. |
|
Incremental code coverage: 100.00% |
avelad
requested changes
Jun 29, 2023
|
So it should be "not mp4 && not webm"? |
I think so |
baconz
force-pushed
the
fix_unnecessary_ts_parse
branch
from
e3f16a0 to
6fbb30c
Compare
baconz
changed the title
joeyparrish
approved these changes
Jun 29, 2023
avelad
approved these changes
Jun 29, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see a bunch of audio segments that probe as TS, and thus trigger warnings (and unnecessary work) in appendBuffer. There should never be an MP4 mime type that probes successfully as a TS, right?
Here's an example fmp4 that probes as a TS (ignore the isma file extension).