Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add preferredVideoHdrLevel config. #5370

Merged
merged 8 commits into from
Jun 29, 2023
Merged

Conversation

theodab
Copy link
Contributor

@theodab theodab commented Jun 29, 2023

This configuration value allows the manifest variants to be filtered based on the HDR level of their video stream. This is set to an auto-detect setting, which chooses PQ or SDR based on the device's detected capabilities.

This configuration value allows the manifest variants to be
filtered based on the HDR level of their video stream.
This is set to SDR by default, since testing shows that PQ
streams might not play properly on Chrome.
@theodab theodab added type: enhancement New feature or request browser: Chrome Issues affecting Chrome or Chromium derivatives (except Edge) labels Jun 29, 2023
@avelad avelad added this to the v4.4 milestone Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Incremental code coverage: 90.70%

@avelad avelad requested review from joeyparrish and avelad June 29, 2023 09:47
@theodab theodab merged commit 2f511a2 into shaka-project:main Jun 29, 2023
@theodab theodab deleted the hdrBranch branch June 29, 2023 10:16
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: Chrome Issues affecting Chrome or Chromium derivatives (except Edge) status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants