Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebVTT): Add support to middle position #5366

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 28, 2023

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Jun 28, 2023
@avelad avelad added this to the v4.4 milestone Jun 28, 2023
@avelad avelad requested review from joeyparrish and theodab June 28, 2023 09:11
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@joeyparrish joeyparrish merged commit 5691d5e into shaka-project:main Jun 28, 2023
@avelad avelad deleted the webvtt-middle-position branch June 29, 2023 06:50
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants