Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EC3 transmuxer #5352

Merged
merged 2 commits into from
Jun 27, 2023
Merged

feat: Add EC3 transmuxer #5352

merged 2 commits into from
Jun 27, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 25, 2023

No description provided.

@avelad avelad added this to the v4.4 milestone Jun 25, 2023
@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking labels Jun 25, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 40.53%

lib/transmuxer/ec3.js Outdated Show resolved Hide resolved
lib/transmuxer/ec3_transmuxer.js Show resolved Hide resolved
/** @type {shaka.util.Mp4Generator.StreamInfo} */
const streamInfo = {
timescale: sampleRate,
duration: duration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

@avelad avelad requested a review from theodab June 26, 2023 19:59
@avelad avelad merged commit 7d24e14 into shaka-project:main Jun 27, 2023
@avelad avelad deleted the ec3-transmuxer branch June 27, 2023 05:58
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants