Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get the correct timescale when there are two trak boxes #5327

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 19, 2023

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Jun 19, 2023
@avelad avelad added this to the v4.4 milestone Jun 19, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great otherwise. Nice fix!

lib/util/mp4_box_parsers.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish June 20, 2023 20:05
@avelad avelad merged commit 022f6b9 into shaka-project:main Jun 20, 2023
@avelad avelad deleted the hls-timescale branch June 20, 2023 21:14
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants