Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix live playlist update when using no LL in a LL stream #5282

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix(HLS): Fix live playlist update when using no LL in a LL stream #5282

merged 1 commit into from
Jun 12, 2023
+13 −8

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 12, 2023

This happens because the last segment in an LL stream may not be complete and may not have EXTINF

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Jun 12, 2023
@avelad avelad added this to the v4.4 milestone Jun 12, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad
Copy link
Member Author

avelad commented Jun 12, 2023

Example:

#EXTM3U
#EXT-X-VERSION:8
#EXT-X-TARGETDURATION:2
#EXT-X-SERVER-CONTROL:CAN-BLOCK-RELOAD=YES,HOLD-BACK=6.000,PART-HOLD-BACK=1.440
#EXT-X-PART-INF:PART-TARGET=0.48
#EXT-X-MEDIA-SEQUENCE:878437174
#EXT-X-INDEPENDENT-SEGMENTS
#EXT-X-MAP:URI="test_dolby-hvc1_1000000=1-init.mp4"
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:06.480000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328266324-dur=96-seq=878437174.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:08.400000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328266420-dur=96-seq=878437175.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:10.320000Z
#EXTINF:0.34,
test_dolby-hvc1_1000000=1-begin=84328266516-dur=17-seq=878437176.m4s
#EXT-X-CUE-OUT:DURATION=30.000,ID=1,SCTE35="/DAlAAAAAAAAAP/wFAUAAAABf+/+h+35aP4AKTLgAAEAAAAAJhwTYg=="
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:10.660000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328266533-dur=96-seq=878437177.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:12.580000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328266629-dur=96-seq=878437178.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:14.500000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328266725-dur=96-seq=878437179.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:16.420000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328266821-dur=96-seq=878437180.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:18.340000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328266917-dur=96-seq=878437181.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:20.260000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267013-dur=96-seq=878437182.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:22.180000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267109-dur=96-seq=878437183.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:24.100000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267205-dur=96-seq=878437184.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:26.020000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267301-dur=96-seq=878437185.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:27.940000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267397-dur=96-seq=878437186.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:29.860000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267493-dur=96-seq=878437187.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:31.780000Z
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267589-dur=96-seq=878437188.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:33.700000Z
#EXT-X-PART:DURATION=0.48,INDEPENDENT=YES,URI="test_dolby-hvc1_1000000=1-begin=84328267685-seq=878437189-part=84328267685.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267685-seq=878437189-part=84328267709.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267685-seq=878437189-part=84328267733.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267685-seq=878437189-part=84328267757.m4s"
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267685-dur=96-seq=878437189.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:35.620000Z
#EXT-X-PART:DURATION=0.48,INDEPENDENT=YES,URI="test_dolby-hvc1_1000000=1-begin=84328267781-seq=878437190-part=84328267781.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267781-seq=878437190-part=84328267805.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267781-seq=878437190-part=84328267829.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267781-seq=878437190-part=84328267853.m4s"
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267781-dur=96-seq=878437190.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:37.540000Z
#EXT-X-PART:DURATION=0.48,INDEPENDENT=YES,URI="test_dolby-hvc1_1000000=1-begin=84328267877-seq=878437191-part=84328267877.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267877-seq=878437191-part=84328267901.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267877-seq=878437191-part=84328267925.m4s"
#EXT-X-PART:DURATION=0.48,URI="test_dolby-hvc1_1000000=1-begin=84328267877-seq=878437191-part=84328267949.m4s"
#EXTINF:1.92,
test_dolby-hvc1_1000000=1-begin=84328267877-dur=96-seq=878437191.m4s
#EXT-X-PROGRAM-DATE-TIME:2023-06-12T10:22:39.460000Z
#EXT-X-PART:DURATION=0.48,INDEPENDENT=YES,URI="test_dolby-hvc1_1000000=1-begin=84328267973-seq=878437192-part=84328267973.m4s"
#EXT-X-PRELOAD-HINT:TYPE=PART,URI="test_dolby-hvc1_1000000=1-begin=84328267973-seq=878437192-part=84328267997.m4s"
#EXT-X-RENDITION-REPORT:URI="test_dolby-evte_0=2.m3u8",LAST-MSN=878157655,LAST-PART=0

@avelad avelad merged commit ad2eef6 into shaka-project:main Jun 12, 2023
@avelad avelad deleted the fix-last-target-duration branch June 12, 2023 10:52
@github-actions github-actions bot mentioned this pull request Jun 12, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @theodab