fix(Demo): Allow enable LL only with Low Latency Mode config #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
changed the title
avelad
changed the title
|
Incremental code coverage: No instrumented code was changed. |
theodab
reviewed
Jun 9, 2023
| @@ -1227,9 +1227,8 @@ shakaDemo.Main = class { | |||
| // Remove all not-player-applied configurations, by resetting the | |||
| // configuration then re-applying the desired configuration. | |||
| this.player_.resetConfiguration(); | |||
| this.player_.configure(this.desiredConfig_); | |||
| this.readHash_(); | |||
There was a problem hiding this comment.
So I did some practical testing, and couldn't find any evidence that this PR leads to the hash or desiredConfig_ values changing.
It's possible that comment below was true at some earlier point in the demo app's development...
Anyway, this is probably safe.
theodab
approved these changes
Jun 9, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all config is passed to the player but some config parameters are untouched, we need only pass the config params that are different, to allow enable LL with only one change.