feat: Add support for changing codecs in MediaSourceEngine #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
avelad
force-pushed
the
reset-changeType-mse
branch
2 times, most recently
from
b67f3d7 to
d2cf831
Compare
|
Incremental code coverage: 63.73% |
avelad
force-pushed
the
reset-changeType-mse
branch
from
d2cf831 to
4d8b9bd
Compare
theodab
requested changes
May 10, 2023
theodab
requested changes
May 11, 2023
This reverts commit f002610.
theodab
approved these changes
May 11, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #4766
This PR adds support for codec hot-switching in MediaSourceEngine.
There are two ways to change codec:
Sourcebuffer.changeTypeon supported browsersMediaSourceinstance with the new codecsThis change does not change the current filter logic, so this code is not used yet. The change in the filtering will be done in a subsequent PR in order to simplify the changes of this PR.