Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Transmux containerless to the correct mimetype #5205

Merged
merged 2 commits into from
May 3, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented May 2, 2023

With this change, the manifest codecs are not filtered when using a raw format, now it is filtered only when necessary.

@avelad avelad added component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels May 2, 2023
@avelad avelad added this to the v4.4 milestone May 2, 2023
@avelad avelad added the type: bug Something isn't working correctly label May 2, 2023
@joeyparrish
Copy link
Member

It looks like you're removing code paths that enable containerless content to work without transmuxing.

@avelad avelad marked this pull request as draft May 2, 2023 17:32
@avelad
Copy link
Member Author

avelad commented May 2, 2023

It looks like you're removing code paths that enable containerless content to work without transmuxing.

You're right, I need to make some more changes.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Incremental code coverage: 100.00%

@avelad avelad force-pushed the transmuxer-containerless-codec branch from 532ea3d to b855703 Compare May 2, 2023 18:49
@avelad avelad marked this pull request as ready for review May 2, 2023 19:07
@avelad avelad force-pushed the transmuxer-containerless-codec branch 3 times, most recently from 54a530b to 31a3c39 Compare May 2, 2023 19:52
@avelad avelad force-pushed the transmuxer-containerless-codec branch from 31a3c39 to da8d3b2 Compare May 2, 2023 19:54
theodab
theodab previously approved these changes May 2, 2023
lib/util/mime_utils.js Outdated Show resolved Hide resolved
test/player_integration.js Outdated Show resolved Hide resolved
@avelad avelad merged commit bb40d3b into shaka-project:main May 3, 2023
@avelad avelad deleted the transmuxer-containerless-codec branch May 3, 2023 08:33
@joeyparrish
Copy link
Member

This change did not cherry-pick cleanly to v4.2.x. If you think the fix is needed in v4.2.x, please create a new PR against that branch to backport it.

@joeyparrish
Copy link
Member

Same for v4.3.x.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants