Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix support of fragmented WebVTT #5156

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix(HLS): Fix support of fragmented WebVTT #5156

merged 1 commit into from
Apr 18, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 18, 2023

Fixes #5076

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles labels Apr 18, 2023
@avelad avelad added this to the v4.4 milestone Apr 18, 2023
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Apr 18, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 92.31%

@avelad avelad merged commit 9c4a61f into shaka-project:main Apr 18, 2023
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Merged
@avelad avelad deleted the hls-mp4-vtt branch April 19, 2023 07:19
joeyparrish pushed a commit that referenced this pull request Apr 26, 2023
@avelad @joeyparrish
fix(HLS): Fix support of fragmented WebVTT (#5156)
e54a52b 
Fixes #5076
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Enabling WebVTT Segmented Subtitles in HLS fails on first try. Works on second intent.
2 participants
@avelad @joeyparrish