Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ads): Fix SS configure #5155

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix(Ads): Fix SS configure #5155

merged 1 commit into from
Apr 17, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 17, 2023

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Apr 17, 2023
@avelad avelad added this to the v4.4 milestone Apr 17, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 0.00%

@avelad avelad merged commit 49ed4ab into shaka-project:main Apr 17, 2023
@github-actions github-actions bot mentioned this pull request Apr 17, 2023
Merged
@avelad avelad deleted the ad-manager-fix branch April 18, 2023 07:03
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @littlespex