Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reject TS content on Edge #5043

Merged
merged 3 commits into from
Feb 28, 2023
Merged

fix: Reject TS content on Edge #5043

merged 3 commits into from
Feb 28, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 28, 2023

Fixes #4955

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release browser: Edge Issues affecting Microsoft Edge (any version) labels Feb 28, 2023
@avelad avelad added this to the v4.4 milestone Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023 •
edited
Loading

Incremental code coverage: 63.16%

theodab
theodab requested changes Feb 28, 2023
View reviewed changes
lib/polyfill/mediasource.js Outdated Show resolved Hide resolved
lib/polyfill/mediasource.js Outdated Show resolved Hide resolved
lib/polyfill/mediasource.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab February 28, 2023 14:55
@avelad avelad merged commit 8818a02 into shaka-project:main Feb 28, 2023
@avelad
Copy link
Member Author

avelad commented Feb 28, 2023

Thanks @theodab

@github-actions github-actions bot mentioned this pull request Feb 28, 2023
Merged
@avelad avelad deleted the ts-edge branch February 28, 2023 20:12
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
@avelad @joeyparrish
fix: Reject TS content on Edge (#5043)
2d6e8ee 
Fixes #4955
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
@avelad @joeyparrish
fix: Reject TS content on Edge (#5043)
99fb4bb 
Fixes #4955
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Mar 1, 2023
@avelad @joeyparrish
fix: Reject TS content on Edge (#5043)
982d7bc 
Fixes #4955
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Mar 2, 2023
@avelad @joeyparrish
fix: Reject TS content on Edge (#5043)
c5c4d0f 
Fixes #4955
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
browser: Edge Issues affecting Microsoft Edge (any version) priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Live streams not working in Edge browser
2 participants
@avelad @theodab