fix: Prevent error and incorrect duration #5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
theodab
requested changes
Feb 14, 2023
The duration is the minimum of the end times of all active streams. Non-active streams are not guaranteed to have useful maxTimestamp values, due to the lazy-loading system, so they are ignored.
|
@theodab I appreciate your suggestions and am sorry for the poor expression. |
theodab
approved these changes
Feb 16, 2023
|
Thank you for your contribution! |
joeyparrish
pushed a commit
that referenced
this pull request
Mar 1, 2023
The duration is the minimum of the end times of all active streams. Non-active streams are not guaranteed to have useful maxTimestamp values, due to the lazy-loading system, so they are ignored.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duration is the minimum of the end times of all active streams.
Non-active streams are not guaranteed to have useful maxTimestamp
values, due to the lazy-loading system, so they are ignored.