fix(VTT): Fix combining style selectors #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple style blocks exist for the same selector, they should be
combined. For example,
::cue(b) { background: white; }
::cue(b) { color: blue; }
should set both the background and foreground of bold tags.
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
littlespex
approved these changes
Jan 25, 2023
|
Incremental code coverage: 100.00% |
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
When multiple style blocks exist for the same selector, they should be
combined. For example,
::cue(b) { background: white; }
::cue(b) { color: blue; }
should set both the background and foreground of bold tags.
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
When multiple style blocks exist for the same selector, they should be
combined. For example,
::cue(b) { background: white; }
::cue(b) { color: blue; }
should set both the background and foreground of bold tags.
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
When multiple style blocks exist for the same selector, they should be
combined. For example,
::cue(b) { background: white; }
::cue(b) { color: blue; }
should set both the background and foreground of bold tags.
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
When multiple style blocks exist for the same selector, they should be
combined. For example,
::cue(b) { background: white; }
::cue(b) { color: blue; }
should set both the background and foreground of bold tags.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple style blocks exist for the same selector, they should be combined. For example,
::cue(b) { background: white; }
::cue(b) { color: blue; }
should set both the background and foreground of bold tags.