feat(logs): Add extra logging for 3015 errors #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsychoSnake
changed the title
|
Not sure what title prefix should be added to this type of PR as im only adding some logs. If the current one is wrong would appreciate some guidance |
avelad
added
type: enhancement
theodab
requested changes
Jan 27, 2023
lib/media/media_source_engine.js
Outdated
| @@ -1265,6 +1265,7 @@ shaka.media.MediaSourceEngine = class { | |||
| shaka.util.Error.Severity.CRITICAL, | |||
| shaka.util.Error.Category.MEDIA, | |||
| shaka.util.Error.Code.MEDIA_SOURCE_OPERATION_THREW, | |||
| this.video_.error || 'No error in the media element', | |||
There was a problem hiding this comment.
This should be the second data item, not the first, so as to not change the order of the data items. E.g. so that people checking error.data[0] to find what the exception was won't suddenly be seeing the video error instead.
You should also update the documentation for this error code, in lib/util/error.js.
There was a problem hiding this comment.
Makes sense. Have changed it now
lib/media/media_source_engine.js
Outdated
| @@ -1308,6 +1309,7 @@ shaka.media.MediaSourceEngine = class { | |||
| shaka.util.Error.Severity.CRITICAL, | |||
| shaka.util.Error.Category.MEDIA, | |||
| shaka.util.Error.Code.MEDIA_SOURCE_OPERATION_THREW, | |||
| this.video_.error || 'No error in the media element', | |||
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Jan 27, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our PROD app has been getting some 3015 errors where the exception message is as follows:
Error: Failed to execute 'appendBuffer' on 'SourceBuffer': The HTMLMediaElement.error attribute is not nullWe have added some extra logging to add what is inside the error property in hopes of having a better ideia of what is causing it since we ourselves haven't quite been able to reproduce the issue.
Wanted to bring this back to the main repo in case it could help others. Because the exception Shaka gets only has that message so could be useful to know what was the exact error that the media element got that caused the
appendBuffercall to fail.